From e60a03293e77366ed97373382da3838e3d211e61 Mon Sep 17 00:00:00 2001 From: Loic Deridder Date: Wed, 12 Feb 2025 15:53:22 +0100 Subject: [PATCH] leaks --- run_vg.sh | 2 +- srcs/execution/exec_pline.c | 1 + srcs/msh_struct.c | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/run_vg.sh b/run_vg.sh index d4a1c2f..d683474 100755 --- a/run_vg.sh +++ b/run_vg.sh @@ -1 +1 @@ -make && valgrind --leak-check=full --track-origins=yes --show-leak-kinds=all --suppressions=valgrind.supp -s ./minishell +make && valgrind --leak-check=full --track-origins=yes --show-leak-kinds=all --trace-children=yes --track-fds=all --suppressions=valgrind.supp -s ./minishell diff --git a/srcs/execution/exec_pline.c b/srcs/execution/exec_pline.c index 5453769..5f86bcf 100644 --- a/srcs/execution/exec_pline.c +++ b/srcs/execution/exec_pline.c @@ -35,6 +35,7 @@ void exec_pchild(int *pipes, int index, t_ast_n *pcmd, int cmds) ret = 0; if (index < cmds - 1) dup2(pipes[1], STDOUT_FILENO); + close(pcmd->msh->hist); close(pipes[0]); close(pipes[1]); handle_redir(pcmd); diff --git a/srcs/msh_struct.c b/srcs/msh_struct.c index d94091a..acd549f 100644 --- a/srcs/msh_struct.c +++ b/srcs/msh_struct.c @@ -52,6 +52,8 @@ void free_msh(t_msh *msh) free_tab(msh->env); if (msh->hist != -1) close(msh->hist); + if (msh->here_fd != -1) + close(msh->here_fd); free(msh->input); free(msh); }